Commit df7171353b4586d608695395a9a60727bfdca24b

Authored by 648540858
Committed by GitHub
2 parents 44b250ee bdf799fb

Merge pull request #729 from gaofuwang/wvp-28181-2.0

修复WVP作为下级平台接收DeviceInfo指令固定响应的问题
src/main/java/com/genersoft/iot/vmp/gb28181/transmit/cmd/ISIPCommanderForPlatform.java
... ... @@ -51,11 +51,11 @@ public interface ISIPCommanderForPlatform {
51 51 /**
52 52 * 向上级回复DeviceInfo查询信息
53 53 * @param parentPlatform 平台信息
54   - * @param sn
55   - * @param fromTag
  54 + * @param sn SN
  55 + * @param fromTag FROM头的tag信息
56 56 * @return
57 57 */
58   - void deviceInfoResponse(ParentPlatform parentPlatform, String sn, String fromTag) throws SipException, InvalidArgumentException, ParseException;
  58 + void deviceInfoResponse(ParentPlatform parentPlatform,Device device, String sn, String fromTag) throws SipException, InvalidArgumentException, ParseException;
59 59  
60 60 /**
61 61 * 向上级回复DeviceStatus查询信息
... ...
src/main/java/com/genersoft/iot/vmp/gb28181/transmit/cmd/impl/SIPCommanderFroPlatform.java
... ... @@ -293,23 +293,23 @@ public class SIPCommanderFroPlatform implements ISIPCommanderForPlatform {
293 293 * @return
294 294 */
295 295 @Override
296   - public void deviceInfoResponse(ParentPlatform parentPlatform, String sn, String fromTag) throws SipException, InvalidArgumentException, ParseException {
  296 + public void deviceInfoResponse(ParentPlatform parentPlatform,Device device, String sn, String fromTag) throws SipException, InvalidArgumentException, ParseException {
297 297 if (parentPlatform == null) {
298 298 return;
299 299 }
300 300 String characterSet = parentPlatform.getCharacterSet();
301 301 StringBuffer deviceInfoXml = new StringBuffer(600);
302   - deviceInfoXml.append("<?xml version=\"1.0\" encoding=\"" + characterSet + "\"?>\r\n")
303   - .append("<Response>\r\n")
304   - .append("<CmdType>DeviceInfo</CmdType>\r\n")
305   - .append("<SN>" +sn + "</SN>\r\n")
306   - .append("<DeviceID>" + parentPlatform.getDeviceGBId() + "</DeviceID>\r\n")
307   - .append("<DeviceName>" + parentPlatform.getName() + "</DeviceName>\r\n")
308   - .append("<Manufacturer>wvp</Manufacturer>\r\n")
309   - .append("<Model>wvp-28181-2.0</Model>\r\n")
310   - .append("<Firmware>2.0.202107</Firmware>\r\n")
311   - .append("<Result>OK</Result>\r\n")
312   - .append("</Response>\r\n");
  302 + deviceInfoXml.append("<?xml version=\"1.0\" encoding=\"" + characterSet + "\"?>\r\n");
  303 + deviceInfoXml.append("<Response>\r\n");
  304 + deviceInfoXml.append("<CmdType>DeviceInfo</CmdType>\r\n");
  305 + deviceInfoXml.append("<SN>" +sn + "</SN>\r\n");
  306 + deviceInfoXml.append("<DeviceID>" + device.getDeviceId() + "</DeviceID>\r\n");
  307 + deviceInfoXml.append("<DeviceName>" + device.getName() + "</DeviceName>\r\n");
  308 + deviceInfoXml.append("<Manufacturer>" + device.getManufacturer() + "</Manufacturer>\r\n");
  309 + deviceInfoXml.append("<Model>" + device.getModel() + "</Model>\r\n");
  310 + deviceInfoXml.append("<Firmware>" + device.getFirmware() + "</Firmware>\r\n");
  311 + deviceInfoXml.append("<Result>OK</Result>\r\n");
  312 + deviceInfoXml.append("</Response>\r\n");
313 313  
314 314 CallIdHeader callIdHeader = sipSender.getNewCallIdHeader(parentPlatform.getDeviceIp(),parentPlatform.getTransport());
315 315  
... ...
src/main/java/com/genersoft/iot/vmp/gb28181/transmit/event/request/impl/message/query/cmd/DeviceInfoQueryMessageHandler.java
... ... @@ -6,6 +6,7 @@ import com.genersoft.iot.vmp.gb28181.transmit.cmd.impl.SIPCommanderFroPlatform;
6 6 import com.genersoft.iot.vmp.gb28181.transmit.event.request.SIPRequestProcessorParent;
7 7 import com.genersoft.iot.vmp.gb28181.transmit.event.request.impl.message.IMessageHandler;
8 8 import com.genersoft.iot.vmp.gb28181.transmit.event.request.impl.message.query.QueryMessageHandler;
  9 +import com.genersoft.iot.vmp.storager.IVideoManagerStorage;
9 10 import gov.nist.javax.sip.message.SIPRequest;
10 11 import org.dom4j.Element;
11 12 import org.slf4j.Logger;
... ... @@ -21,6 +22,8 @@ import javax.sip.header.FromHeader;
21 22 import javax.sip.message.Response;
22 23 import java.text.ParseException;
23 24  
  25 +import static com.genersoft.iot.vmp.gb28181.utils.XmlUtil.getText;
  26 +
24 27 @Component
25 28 public class DeviceInfoQueryMessageHandler extends SIPRequestProcessorParent implements InitializingBean, IMessageHandler {
26 29  
... ... @@ -32,6 +35,8 @@ public class DeviceInfoQueryMessageHandler extends SIPRequestProcessorParent imp
32 35  
33 36 @Autowired
34 37 private SIPCommanderFroPlatform cmderFroPlatform;
  38 + @Autowired
  39 + private IVideoManagerStorage storager;
35 40  
36 41 @Override
37 42 public void afterPropertiesSet() throws Exception {
... ... @@ -52,10 +57,20 @@ public class DeviceInfoQueryMessageHandler extends SIPRequestProcessorParent imp
52 57 responseAck((SIPRequest) evt.getRequest(), Response.OK);
53 58 } catch (SipException | InvalidArgumentException | ParseException e) {
54 59 logger.error("[命令发送失败] DeviceInfo查询回复: {}", e.getMessage());
  60 + return;
55 61 }
56 62 String sn = rootElement.element("SN").getText();
  63 + /*根据WVP原有的数据结构,设备和通道是分开放置,设备信息都是存放在设备表里,通道表里的设备信息不可作为真实信息处理
  64 + 大部分NVR/IPC设备对他的通道信息实现都是返回默认的值没有什么参考价值。NVR/IPC通道我们统一使用设备表的设备信息来作为返回。
  65 + 我们这里使用查询数据库的方式来实现这个设备信息查询的功能,在其他地方对设备信息更新达到正确的目的。*/
  66 + String channelId = getText(rootElement, "DeviceID");
  67 + Device device = storager.queryDeviceInfoByPlatformIdAndChannelId(parentPlatform.getServerGBId(), channelId);
  68 + if (device ==null){
  69 + logger.error("[平台没有该通道的使用权限]:platformId"+parentPlatform.getServerGBId()+" deviceID:"+channelId);
  70 + return;
  71 + }
57 72 try {
58   - cmderFroPlatform.deviceInfoResponse(parentPlatform, sn, fromHeader.getTag());
  73 + cmderFroPlatform.deviceInfoResponse(parentPlatform,device, sn, fromHeader.getTag());
59 74 } catch (SipException | InvalidArgumentException | ParseException e) {
60 75 logger.error("[命令发送失败] 国标级联 DeviceInfo查询回复: {}", e.getMessage());
61 76 }
... ...
src/main/java/com/genersoft/iot/vmp/storager/IVideoManagerStorage.java
... ... @@ -185,7 +185,13 @@ public interface IVideoManagerStorage {
185 185  
186 186 Device queryVideoDeviceByPlatformIdAndChannelId(String platformId, String channelId);
187 187  
188   -
  188 + /**
  189 + * 针对deviceinfo指令的查询接口
  190 + * @param platformId 平台id
  191 + * @param channelId 通道id
  192 + * @return 设备信息
  193 + */
  194 + Device queryDeviceInfoByPlatformIdAndChannelId(String platformId, String channelId);
189 195 /**
190 196 * 添加Mobile Position设备移动位置
191 197 * @param mobilePosition
... ...
src/main/java/com/genersoft/iot/vmp/storager/dao/PlatformChannelMapper.java
... ... @@ -107,4 +107,11 @@ public interface PlatformChannelMapper {
107 107 "DELETE FROM platform_gb_channel WHERE platformId=#{platformId} and catalogId=#{catalogId}" +
108 108 "</script>")
109 109 int delChannelForGBByCatalogId(String platformId, String catalogId);
  110 +
  111 + @Select("select dc.channelId deviceId,dc.name,d.manufacturer,d.model,d.firmware\n" +
  112 + "from platform_gb_channel pgc\n" +
  113 + " left join device_channel dc on dc.id = pgc.deviceChannelId\n" +
  114 + " left join device d on dc.deviceId = d.deviceId\n" +
  115 + "where dc.channelId = #{channelId} and pgc.platformId=#{platformId}")
  116 + List<Device> queryDeviceInfoByPlatformIdAndChannelId(String platformId, String channelId);
110 117 }
... ...
src/main/java/com/genersoft/iot/vmp/storager/impl/VideoManagerStorageImpl.java
... ... @@ -584,6 +584,20 @@ public class VideoManagerStorageImpl implements IVideoManagerStorage {
584 584  
585 585 }
586 586  
  587 + @Override
  588 + public Device queryDeviceInfoByPlatformIdAndChannelId(String platformId, String channelId) {
  589 + List<Device> devices = platformChannelMapper.queryDeviceInfoByPlatformIdAndChannelId(platformId, channelId);
  590 + if (devices.size() > 1) {
  591 + // 出现长度大于0的时候肯定是国标通道的ID重复了
  592 + logger.warn("国标ID存在重复:{}", channelId);
  593 + }
  594 + if (devices.size() == 0) {
  595 + return null;
  596 + }else {
  597 + return devices.get(0);
  598 + }
  599 + }
  600 +
587 601 /**
588 602 * 查询最新移动位置
589 603 * @param deviceId
... ...